Add the ability to have system-mode without process tracking #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
requested changes
Feb 14, 2024
src/config.cpp
Outdated
| @@ -221,9 +221,11 @@ void parse_program_options(int argc, const char** argv) | |||
| .metavar("NAME") | |||
| .optional(); | |||
|
|
|||
| system_mode_options.toggle("system-wide", | |||
There was a problem hiding this comment.
This option seems confusing. What you want to use is a reversable toggle called process-recording (or something like that) with a default of true.
So you'd call lo2s with .../lo2s -a --no-process-monitoring [...].
There was a problem hiding this comment.
One of the grievances I have with the lo2s CLI is that it is not very orthogonal in places.
However here consistency is probably better than trying to shoehorn in orthogonality...
cvonelm
force-pushed
the
system-mode-without-process-tracking
branch
from
f43776b to
34087e0
Compare
…s tracking This should reduce the overhead in situations where you really only want to track metrics in system-wide mode.
cvonelm
force-pushed
the
system-mode-without-process-tracking
branch
from
34087e0 to
0ed485b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the overhead in situations where you really only want to track metrics in system-wide mode.